pjfanning commented on PR #510: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/510#issuecomment-6413564310
Thanks for the review. 1. **PubSub:** ported separately in #511 (copied from the akka-persistence-r2dbc 1.2.0 tag, noted in that PR's description), so this PR stays focused on the query side. The two together give consistent envelopes from query, backtracking and PubSub. 2. **`"S"` manifest test:** fixed in a641df0, see inline. Agreed that the manifest check is defensive until the M5 bump; storing `SerializedEvent` by its inner serializer id/manifest/bytes in `R2dbcJournal` is a good follow-up once we're on M5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
