The GitHub Actions job "Basic checks" on pekko-projection.git/port-akka-1017-r2dbc-withsession has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: e56bbc84b576e8bcdfa12f98348750ead5d258d8 / PJ Fanning <[email protected]> r2dbc: address review of R2dbcSession.withSession Motivation: Review of #664 asked for Java usage of withSession, docs snippets, config errors reported through the returned Future, a single settings parse, and consistent @ApiMayChange. Modification: - Add #withSession doc snippets to R2dbcProjectionDocExample in Scala and Java. The Java one calls the static forwarders, so it is also a Java compile check. Document them in a new "Using R2dbcSession outside a handler" section with @apidoc[R2dbcSession$]. - Report errors from the connection factory and settings lookup as a failed Future/CompletionStage instead of throwing from withSession. - Parse R2dbcProjectionSettings once per call and use useConnectionFactory, dropping the internal connectionFactoryConfigPath helper (new in this PR, not released). - Annotate the scaladsl and javadsl R2dbcSession objects with @ApiMayChange, like the rest of the module's public API. Result: Java callers have a compiled example and get config errors through the CompletionStage. Tests: - R2dbcSessionSpec: new cases for an unknown connection factory config path (scaladsl and javadsl) fail when the error is rethrown, and pass with the change. 7 passed against local Postgres. - R2dbcProjectionSpec: pass - sbt r2dbc/Test/compile (Java and Scala doc examples) - sbt "r2dbc/mimaReportBinaryIssues": success - sbt scalafmt tasks and r2dbc/javafmtAll (JDK 17) - Not run locally: paradox docs build (left to CI) References: Refs #664 Report URL: https://github.com/apache/pekko-projection/actions/runs/40405775813 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
