pjfanning commented on code in PR #1380:
URL: https://github.com/apache/pekko-http/pull/1380#discussion_r4386042551
##########
http/src/main/scala/org/apache/pekko/http/javadsl/server/Rejections.scala:
##########
@@ -401,23 +401,26 @@ object Rejections {
s.MalformedHeaderRejection(headerName, errorMsg, cause.toScala)
def unsupportedRequestContentType(
- supported: java.lang.Iterable[MediaType],
- contentType: Optional[ContentType]):
UnsupportedRequestContentTypeRejection =
+ supported: java.lang.Iterable[? <: MediaType],
+ contentType: Optional[? <: ContentType]):
UnsupportedRequestContentTypeRejection =
s.UnsupportedRequestContentTypeRejection(
supported = supported.asScala.map((m: MediaType) =>
scaladsl.model.ContentTypeRange(m.asScala)).toSet,
contentType = contentType.toScala.map((c: ContentType) => c.asScala))
// for backwards compatibility
- def unsupportedRequestContentType(supported: java.lang.Iterable[MediaType]):
UnsupportedRequestContentTypeRejection =
+ def unsupportedRequestContentType(
+ supported: java.lang.Iterable[? <: MediaType]):
UnsupportedRequestContentTypeRejection =
Review Comment:
that java.lang.Iterable as input type does not stop anyone posting a
subclass of Iterable to this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
