pjfanning commented on code in PR #3719:
URL: https://github.com/apache/pekko/pull/3719#discussion_r4393620162
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/BidiFlow.scala:
##########
@@ -54,10 +54,10 @@ object BidiFlow {
* }}}
*/
def fromFlowsMat[I1, O1, I2, O2, M1, M2, M](
- flow1: Graph[FlowShape[I1, O1], M1],
- flow2: Graph[FlowShape[I2, O2], M2],
+ flow1: Graph[? <: FlowShape[? >: I1, O1], M1],
Review Comment:
Agreed - a flow's output only flows downstream, so it is now `? <: O`
everywhere a `FlowShape` graph is accepted (`via`/`viaMat`, `join`,
`Flow.fromGraph`, `BidiFlow.fromFlows*`, the with-context `via` operators and
GraphDSL `ForwardOps.via`) in 5d2a96e43f. Added
`mustAcceptFlowsEmittingASubtypeOfTheResultingElementType` tests in
`SourceTest` and `FlowTest` that only compile with the widened output type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
