The GitHub Actions job "Stage release candidate" on pekko-http.git/main has 
failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
c525ae28a6c458a29322dbaeafb91d9036219d61 / Scala Steward 
<[email protected]>
Update scala3-library to 3.3.9 (#1386)

* Update scala3-library to 3.3.9

* only report MiMa signature problems for Scala 2.13

Motivation:
Scala 3.3.9 emits more complete Java generic signatures than 3.3.8, so MiMa
reports 127 IncompatibleSignatureProblems in http and http-core. Erased
descriptors are unchanged, so runtime binary compatibility is unaffected.

Modification:
Add a MiMaSignatureProblems auto plugin that requires the sbt-pekko-build MiMa
plugin (which sets mimaReportSignatureProblems := true) and overrides it to
only report signature problems on Scala 2.13. Drop the setting from Common,
which was applied before the sbt-pekko-build plugin and had no effect.

Result:
MiMa passes on Scala 3.3.9 without a large excludes file.

Tests:
- sbt "++3.3.9" http-core/mimaReportBinaryIssues http/mimaReportBinaryIssues: 
success
- show mimaReportSignatureProblems: false on 3.3.9, true on 2.13

References:
Refs apache/pekko#3538

* honour mimaReportSignatureProblems in validatePullRequest MiMa check

Motivation:
The validatePullRequest MiMa check calls SbtMima.runMima directly and skipped
the mimaReportSignatureProblems filter that mimaReportBinaryIssues applies, so
the Scala 3 build still failed on 127 IncompatibleSignatureProblems.

Modification:
Drop IncompatibleSignatureProblems from the reported problems when
mimaReportSignatureProblems is false.

Result:
validatePullRequest passes on Scala 3.3.9; signature problems are still reported
on Scala 2.13.

Tests:
- sbt "++3.3.9" "show http/mimaResult" "show http-core/mimaResult": NoErrors
- sbt "show http/mimaResult" "show http-core/mimaResult" (2.13): NoErrors

References:
Refs apache/pekko#3538

---------

Co-authored-by: PJ Fanning <[email protected]>

Report URL: https://github.com/apache/pekko-http/actions/runs/40832534805

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to