The GitHub Actions job "Validate and test" on 
pekko-persistence-r2dbc.git/oracle-dialect has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
55545ea2c622eb055453d9c3274d26c9b169aab4 / PJ Fanning 
<[email protected]>
core: support snapshots as starting points with Oracle

Motivation:
After rebasing onto #515, OracleSnapshotDao overrode upsertSql, which is
now built by createUpsertSql, and the Oracle snapshot table had no
db_timestamp and tags columns for the queries that start from snapshots.

Modification:
- OracleSnapshotDao overrides createUpsertSql with MERGE statements with
  and without the db_timestamp and tags columns, stores tags as a JSON
  array, uses the Oracle bucket SQL and the application timestamp
- The Oracle snapshot table has the db_timestamp and tags columns and
  snapshot_slice_idx
- New snapshot_start_from_snapshot_oracle.sql migration script, listed
  in the migration guide
- StartFromSnapshotMigrationScriptSpec and StartFromSnapshotDisabledSpec
  create the legacy table with Oracle types and run the Oracle script
- OracleDialectSpec uses the new SerializedSnapshotRow fields

Result:
The Oracle dialect compiles after the rebase and supports the queries
that use snapshots as starting points.

Tests:
- sbt Test/compile migration/Test/compile headerCheckAll: success
- sbt -Dpekko.persistence.r2dbc.dialect=h2 "core/testOnly *Snapshot*
  *oracle*": 53 succeeded, 0 failed
- Oracle: not run locally (no Docker daemon), left to the CI Oracle job
- scalafmt: clean

References:
Rebase of #532 onto #515

Report URL: 
https://github.com/apache/pekko-persistence-r2dbc/actions/runs/41126247353

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to