He-Pin opened a new pull request, #3742: URL: https://github.com/apache/pekko/pull/3742
### Motivation `BasicClusterConfigSpec` fails in the nightly classic-remoting job because its seed addresses use `pekko://` and loopback while classic remoting uses `pekko.tcp://` and the host IP. The membership assertions added in #3657 exposed this existing configuration mismatch; the earlier test only started the systems. ### Modification - Select the seed protocol from the transport configuration, including the nightly JVM override. - Bind classic remoting to `127.0.0.1` to match the seed addresses. - Assert member protocols and hosts alongside the existing distinct-port and two-member `Up` assertions. ### Result Both nodes form the expected cluster with Artery or classic remoting. The change is confined to test setup and assertions; all published documentation snippets remain unchanged. ### Tests Validation used Temurin JDK 17.0.21. - Before the fix, `sbt -Dpekko.remote.artery.enabled=off "cluster-typed / Test / testOnly docs.org.apache.pekko.cluster.typed.BasicClusterConfigSpec"` reproduced the timeout with 0 members instead of 2. - After the fix, `BasicClusterConfigSpec` and `BasicClusterManualSpec` passed with default Artery and with `-Dpekko.remote.artery.enabled=off`: 3 tests per run. - Native scalafmt, `headerCreateAll`, `checkCodeStyle` (including `+headerCheckAll` for Scala 2.13 and 3), and `git diff --check`: passed. - `validatePullRequest` with multi-node tests disabled: cluster-typed (77 tests), cluster-sharding-typed (104 tests), and docs (372 tests) passed. The persistence-typed test JVM failed because LevelDB JNI contains x86 binaries incompatible with this ARM Mac. - Reran `persistence-typed / pr-validation:test` with `-Dpekko.persistence.journal.leveldb.native=off -Dpekko.persistence.journal.leveldb-shared.store.native=off`: all 47 tests passed using the supported Java LevelDB implementation. - Qoder CLI review in auditable `--print --output-format stream-json` mode: no must-fix findings. ### References Fixes #3741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
