pjfanning commented on code in PR #532:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/532#discussion_r4480623019
##########
project/Dependencies.scala:
##########
@@ -83,6 +87,7 @@ object Dependencies {
r2dbcMariadb % "provided,test",
r2dbcH2 % "provided,test",
h2 % "provided,test",
+ r2dbcOracle % Test,
Review Comment:
I think 'provided,test' is ok here as it means that our pom won't cause the
jar to be downloaded - any user will need to add their own dependency in their
build script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]