The GitHub Actions job "Running Copilot Code Review" on pekko-http.git/main has failed. Run started by GitHub user Copilot (triggered by Copilot).
Head commit for run: fe8acf6e5b7b38ec729df841ce4002fce79425b4 / PJ Fanning <[email protected]> accept wildcard element types in Java API Rejection factories (#1380) * accept wildcard element types in Java API Rejection factories Motivation: Java generics are invariant, so a caller holding a List<MethodRejection>, a List<MediaType.Binary> or an Optional<ContentType.WithFixedCharset> could not pass it to the Java API rejection factories. Modification: Widen RouteResults.rejected to Iterable<? extends Rejection>, Rejections.unsatisfiableRange to Iterable<? extends ByteRange>, and both Rejections.unsupportedRequestContentType overloads to Iterable<? extends MediaType> / Optional<? extends ContentType>. Add MiMa excludes for the generic-signature-only changes. Result: Java callers can pass collections and optionals of subtypes. The erased signatures are unchanged. Tests: - sbt "http-tests/Test/testOnly org.apache.pekko.http.javadsl.server.RejectionsTest" - passed on Scala 2.13 and 3.3.8 - sbt http/mimaReportBinaryIssues - passed References: Refs #1378 * test Rejection factory Iterable parameters with non-List Iterables Motivation: The new wildcard Iterable parameters should accept any java.lang.Iterable, not just Lists. Modification: Run RouteResults.rejected, Rejections.unsupportedRequestContentType and Rejections.unsatisfiableRange with the same elements as an ArrayList, LinkedHashSet, ArrayDeque, unmodifiable Collection and a non-Collection Iterable. Add tests that the Iterable is traversed once, and that rejected keeps different rejection types in order and accepts an empty Iterable. Result: The Java API rejection factories are tested with several Iterable shapes. Tests: - sbt "http-tests/Test/testOnly org.apache.pekko.http.javadsl.server.RejectionsTest" - passed References: Refs #1378 Report URL: https://github.com/apache/pekko-http/actions/runs/42073783228 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
