pjfanning commented on code in PR #1394:
URL: https://github.com/apache/pekko-http/pull/1394#discussion_r4485918712
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/settings/Http2ClientSettings.scala:
##########
@@ -126,4 +127,36 @@ trait Http2ClientSettings { self:
scaladsl.settings.Http2ClientSettings.Http2Cli
def withMaxConnectionBackoff(backoff: Duration): Http2ClientSettings =
copy(maxConnectionBackoff = backoff.toMillis.millis)
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleFrameTypes(): java.util.Set[String] =
frameTypeThrottleFrameTypes.asJava
Review Comment:
Added `withFrameTypeThrottleCost` and `withFrameTypeThrottleBurst` to the
javadsl `Http2ClientSettings` in 41d118a44, and the same setters plus
`withFrameTypeThrottleFrameTypes` to the javadsl `Http2ServerSettings` in
fe0a8b469.
Leaving `getFrameTypeThrottleInterval` without `()`: it matches the other
`Duration` getters in this trait, such as `getPingInterval` and
`getCompletionTimeout`, and the server's getter of the same name.
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/settings/Http2ClientSettings.scala:
##########
@@ -126,4 +127,36 @@ trait Http2ClientSettings { self:
scaladsl.settings.Http2ClientSettings.Http2Cli
def withMaxConnectionBackoff(backoff: Duration): Http2ClientSettings =
copy(maxConnectionBackoff = backoff.toMillis.millis)
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleFrameTypes(): java.util.Set[String] =
frameTypeThrottleFrameTypes.asJava
+
+ /**
+ * @since 2.0.0
+ */
+ def withFrameTypeThrottleFrameTypes(frameTypes: java.util.Set[String]):
Http2ClientSettings =
+ copy(frameTypeThrottleFrameTypes = frameTypes.asScala.toSet)
Review Comment:
Added `withFrameTypeThrottleCost` and `withFrameTypeThrottleBurst` to the
javadsl `Http2ClientSettings` in 41d118a44, and the same setters plus
`withFrameTypeThrottleFrameTypes` to the javadsl `Http2ServerSettings` in
fe0a8b469.
Leaving `getFrameTypeThrottleInterval` without `()`: it matches the other
`Duration` getters in this trait, such as `getPingInterval` and
`getCompletionTimeout`, and the server's getter of the same name.
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/settings/Http2ClientSettings.scala:
##########
@@ -126,4 +127,36 @@ trait Http2ClientSettings { self:
scaladsl.settings.Http2ClientSettings.Http2Cli
def withMaxConnectionBackoff(backoff: Duration): Http2ClientSettings =
copy(maxConnectionBackoff = backoff.toMillis.millis)
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleFrameTypes(): java.util.Set[String] =
frameTypeThrottleFrameTypes.asJava
+
+ /**
+ * @since 2.0.0
+ */
+ def withFrameTypeThrottleFrameTypes(frameTypes: java.util.Set[String]):
Http2ClientSettings =
+ copy(frameTypeThrottleFrameTypes = frameTypes.asScala.toSet)
+
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleCost(): Int = frameTypeThrottleCost
Review Comment:
Added `withFrameTypeThrottleCost` and `withFrameTypeThrottleBurst` to the
javadsl `Http2ClientSettings` in 41d118a44, and the same setters plus
`withFrameTypeThrottleFrameTypes` to the javadsl `Http2ServerSettings` in
fe0a8b469.
Leaving `getFrameTypeThrottleInterval` without `()`: it matches the other
`Duration` getters in this trait, such as `getPingInterval` and
`getCompletionTimeout`, and the server's getter of the same name.
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/settings/Http2ClientSettings.scala:
##########
@@ -126,4 +127,36 @@ trait Http2ClientSettings { self:
scaladsl.settings.Http2ClientSettings.Http2Cli
def withMaxConnectionBackoff(backoff: Duration): Http2ClientSettings =
copy(maxConnectionBackoff = backoff.toMillis.millis)
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleFrameTypes(): java.util.Set[String] =
frameTypeThrottleFrameTypes.asJava
+
+ /**
+ * @since 2.0.0
+ */
+ def withFrameTypeThrottleFrameTypes(frameTypes: java.util.Set[String]):
Http2ClientSettings =
+ copy(frameTypeThrottleFrameTypes = frameTypes.asScala.toSet)
+
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleCost(): Int = frameTypeThrottleCost
+
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleBurst(): Int = frameTypeThrottleBurst
+
+ /**
+ * @since 2.0.0
+ */
+ def getFrameTypeThrottleInterval: Duration =
Duration.ofMillis(frameTypeThrottleInterval.toMillis)
+
+ /**
+ * @since 2.0.0
+ */
Review Comment:
Added `withFrameTypeThrottleCost` and `withFrameTypeThrottleBurst` to the
javadsl `Http2ClientSettings` in 41d118a44, and the same setters plus
`withFrameTypeThrottleFrameTypes` to the javadsl `Http2ServerSettings` in
fe0a8b469.
Leaving `getFrameTypeThrottleInterval` without `()`: it matches the other
`Duration` getters in this trait, such as `getPingInterval` and
`getCompletionTimeout`, and the server's getter of the same name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
