The GitHub Actions job "Unit Tests" on 
pekko-persistence-cassandra.git/test-pekko-2.0.0-rc1 has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
6d99787fb4a0f6a99b7bad00f054f6359d4e1864 / PJ Fanning 
<[email protected]>
test: make corrupt snapshots in CassandraSnapshotStoreSpec really 
undeserializable

Motivation:
The spec bound ser_id and ser_manifest in the wrong order, so corrupt rows
resolved to NullSerializer (id 0) with a garbage manifest. They only failed
because Pekko tried to load the manifest as a class. Since apache/pekko#3495
(Pekko 2.0.0) that lookup is skipped, so the rows load with a null payload and
the snapshot load retry tests fail.

Modification:
Bind the columns in the right order and use a serializer id with no registered
serializer. Fixing the order alone is not enough, because ByteArraySerializer
(id 4) deserializes the bytes successfully.

Result:
The retry tests exercise a real deserialization failure and pass on Pekko 2.0.0.

Tests:
- sbt "core / Test / testOnly 
org.apache.pekko.persistence.cassandra.snapshot.CassandraSnapshotStoreSpec" 
against docker compose cassandra3: 18 passed
- scalafmt --test on the changed file: passed

References:
Refs apache/pekko#3749

Report URL: 
https://github.com/apache/pekko-persistence-cassandra/actions/runs/42126658536

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to