pjfanning opened a new pull request, #676: URL: https://github.com/apache/pekko-projection/pull/676
### Motivation The root project does not aggregate the int-test modules, so `+Test/compile` in Check Code Compilation skips them, and the gRPC integration workflow only uses Scala 2.13. As a result `grpc-int-test` stopped compiling on Scala 3 without CI noticing. ### Modification - Add `grpc-int-test`, `jdbc-int-test`, `r2dbc-int-test` and `slick-int-test` to the cross-compile step in `checks.yml`. They stay out of the root aggregate because the unit test job runs `test` from root and these modules need external services. - Replace `Http(system)` with `Http()` in `ProducerFilterEndToEndSpec`, matching the other specs in the module, and with `Http()(system)` in `ReplicationIntegrationSpec`, where `system` is a local value. - Add parentheses around the typed lambda parameter in `ReplicationJavaDSLIntegrationSpec`. ### Result All four int-test modules compile on Scala 2.13 and 3.3, and Check Code Compilation fails if they stop compiling. ### Tests - `sbt "+grpc-int-test/Test/compile ; +jdbc-int-test/Test/compile ; +r2dbc-int-test/Test/compile ; +slick-int-test/Test/compile"`: success on 2.13.18 and 3.3.9 - Before the fix, `sbt "++3.3.9" "grpc-int-test/Test/compile"` failed on `main` with four errors - Int-test specs not run locally - left to CI - scalafmt not run - left to the Code is formatted CI job - Scala 3.9.0 not checked; the cross-compile step covers 2.13 and 3.3 only ### References None - found while investigating the Pekko 2.0.0 update in #674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
