The GitHub Actions job "Pull Requests" on pekko.git/fix-null-serializer-non-empty-input has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 21fb4b231de2810938c3c5498df8f661184690d6 / PJ Fanning <[email protected]> fix: reject a non-empty manifest for serializer id 0 Motivation: Since #3495, Serialization.deserialize(empty, 0, "not-a-class") returns Success(null). 2.0.0-M4 failed with NotSerializableException. A real serialized null always has an empty manifest, so this input cannot have come from a conforming sender. Modification: Serialization.deserializeByteArray throws NotSerializableException for NullSerializer with a non-empty manifest. The check only tests whether the manifest is empty, so #3495 stays in place and nothing is loaded. Result: An unresolvable manifest with serializer id 0 fails as it did in 2.0.0-M4. A loadable manifest also fails, where 2.0.0-M4 returned Success(null), because matching that would need the class lookup that #3495 removed. Tests: - sbt "actor-tests/testOnly org.apache.pekko.serialization.*": 172 passed (the new test failed before the fix) - sbt actor/mimaReportBinaryIssues: no issues - docs/paradox: not run locally, left to CI References: Fixes #3752 Report URL: https://github.com/apache/pekko/actions/runs/42167902635 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
