pjfanning opened a new pull request, #553: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/553
### Motivation The `EventSourced` and `DurableState` test behaviors in `RuntimePluginConfigSpec` define and handle `ShowMeWhatYouGot` and `Stop`, but the spec never sends them. It only sends `Save`, and checks the stored data through the plugins directly. ### Modification - Remove `ShowMeWhatYouGot` and `Stop`, and their handlers, from both behaviors. This is the first option in the issue. - Replace the `state` parameter of the `EventSourced` command handler with `_`, since nothing uses it now. ### Result The test behaviors only contain the command the spec uses. There is no production code change and the assertions are unchanged. ### Tests This change only removes unused test code, so it adds no new test. - H2, Scala 2.13: `sbt -Dpekko.persistence.r2dbc.dialect=h2 "core/testOnly *RuntimePluginConfigSpec"`: 2 of 2 passed - H2, Scala 3.3.9: `sbt "++3.3.9" -Dpekko.persistence.r2dbc.dialect=h2 "core/testOnly *RuntimePluginConfigSpec"`: 2 of 2 passed - `scalafmt --mode diff-ref=upstream/main`, `sbt core/Test/scalafmtCheck` and `git diff --check`: clean - PostgreSQL and the other databases not run locally, left to CI ### References Fixes #527. Refs #526, #203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
