DLotts commented on a change in pull request #315:
URL: https://github.com/apache/rya/pull/315#discussion_r521659861
##########
File path: pom.xml
##########
@@ -69,38 +69,38 @@ under the License.
<module>web</module>
</modules>
<properties>
- <org.eclipse.rdf4j.version>2.3.1</org.eclipse.rdf4j.version> <!--
Newest: 2.3.1 -->
+ <org.eclipse.rdf4j.version>3.2.2</org.eclipse.rdf4j.version>
- <accumulo.version>1.6.4</accumulo.version> <!-- Newest: 1.7.0 -->
- <hadoop.version>2.5.0</hadoop.version> <!-- Newest: 2.7.1 -->
+ <accumulo.version>1.9.3</accumulo.version>
Review comment:
1.9.3 was probably the latest when you did this. How difficult would be
to go to Accumulo version to 1.10.0 -- their LTM release? I'm perfectly fine
with accepting this as is, as you did lots of working getting this done.
Perhaps you have already done this, so I thought I would bring it up.
##########
File path: pom.xml
##########
@@ -69,38 +69,38 @@ under the License.
<module>web</module>
</modules>
<properties>
- <org.eclipse.rdf4j.version>2.3.1</org.eclipse.rdf4j.version> <!--
Newest: 2.3.1 -->
+ <org.eclipse.rdf4j.version>3.2.2</org.eclipse.rdf4j.version>
Review comment:
Wow, RDF4J is moving fast. It is now at 3.4.3. I believe that you used
the latest version when you did this work. How hard would it be to use the
latest (again)?
##########
File path:
extras/indexing/src/main/java/org/apache/rya/indexing/entity/model/Property.java
##########
@@ -18,21 +18,21 @@
*/
package org.apache.rya.indexing.entity.model;
-import static java.util.Objects.requireNonNull;
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;
+import org.apache.http.annotation.Contract;
+import org.apache.http.annotation.ThreadingBehavior;
+import org.apache.rya.api.domain.RyaIRI;
+import org.apache.rya.api.domain.RyaType;
import java.util.Objects;
-import org.apache.http.annotation.Immutable;
-import org.apache.rya.api.domain.RyaType;
-import org.apache.rya.api.domain.RyaIRI;
-
-import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
-import edu.umd.cs.findbugs.annotations.NonNull;
+import static java.util.Objects.requireNonNull;
/**
* A value that has been set for an {@link TypedEntity}.
*/
-@Immutable
+@Contract(threading = ThreadingBehavior.IMMUTABLE)
Review comment:
Explainer:
https://dev-aux.com/java/org-apache-http-annotation-threadsafe-class-not-found
##########
File path:
extras/rya.streams/api/src/test/java/org/apache/rya/streams/api/queries/InMemoryQueryRepositoryTest.java
##########
@@ -83,7 +82,7 @@ public void initializedWithPopulatedChangeLog() throws
Exception {
final QueryChangeLog changeLog = new InMemoryQueryChangeLog();
final QueryRepository queries = new InMemoryQueryRepository(
changeLog, SCHEDULE );
try {
- queries.startAndWait();
+ queries.startAsync();
Review comment:
Why? Did you have a source article for these changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
