[
https://issues.apache.org/jira/browse/RYA-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177948#comment-15177948
]
ASF GitHub Bot commented on RYA-7:
----------------------------------
Github user joshelser commented on the pull request:
https://github.com/apache/incubator-rya/pull/25#issuecomment-191813364
> We have those exclusions in the parent pom, we have apache-rat check
enabled by default, and everything works as expected if we do a mvn clean
install (i.e. the exclusions are propagagted to the submodules).
Oh interesting. I assume you mean that the apache-rat check is running with
the `mvn clean install`? It could just be a configuration issue.
> However those exclusions aren't propagated if we do a mvn
apache-rat:check
IIRC, you should really set the configuration in each sub-module. There are
defaults (such as target/) which are automatically included via the apache
parent pom, but it's good practice to localize any exclusions to the rat check
in the sub-modules (to avoid unexpected exclusions). I can try to help you out
with this if you get stuck.
> I don't understand why apache-rat didn't catch the "Copyright Rya" in
these two files. (And I really don't understand how you caught that either :)
). Is there a more stringent setting for apache-rat?
I just grep'ed for Copyright. The license header might have been close
enough to the ASL that it passed the RAT check, but I was more looking for
places where you had copyrights listed (the rules are that you don't include a
copyright for ASF-owned code).
> Various pom cleanups for the Apache move
> ----------------------------------------
>
> Key: RYA-7
> URL: https://issues.apache.org/jira/browse/RYA-7
> Project: Rya
> Issue Type: Task
> Reporter: Josh Elser
> Assignee: Aaron Mihalik
> Fix For: 3.2.10
>
>
> In working on RYA-5, I noticed a few things in the pom that I believe should
> be taken care of before a release.
> * Make the apache pom the parent (see https://maven.apache.org/pom/asf/)
> * Depend on Apache releases for Hadoop and ZooKeeper (and groovy?)
> * Make sure we're depending on the most recent bug-fix release for
> dependencies (e.g. upgrade from 1.6.2 to 1.6.4 for Accumulo)
> * Change groupId from {{mvn.rya}} to {{org.apache.rya}} for consistency with
> other Maven-based ASF projects
> * Set proper names for each maven module (instead of groupid.artifact). This
> isn't as critical to change for a release, but just is an easy thing to
> improve.
> * Fix SCM block in parent pom (points to incorrect repository).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
