[jira] [Commented] (RYA-53) Add Visibility to Rya PCJs

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/RYA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230635#comment-15230635
 ] 

ASF GitHub Bot commented on RYA-53:
-----------------------------------

Github user isper3at commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/36#discussion_r58911417
  
    --- Diff: 
extras/indexing/src/test/java/mvm/rya/indexing/external/tupleSet/PcjTablesIntegrationTests.java
 ---
    @@ -151,35 +151,39 @@ public void addResults() throws PcjException, 
TableNotFoundException, BindingSet
     
             // Create a PCJ table in the Mini Accumulo.
             final String pcjTableName = new 
PcjTableNameFactory().makeTableName(RYA_TABLE_PREFIX, "testPcj");
    -        Set<VariableOrder> varOrders = new 
ShiftVarOrderFactory().makeVarOrders(new VariableOrder("name;age"));
    -        PcjTables pcjs = new PcjTables();
    +        final Set<VariableOrder> varOrders = new 
ShiftVarOrderFactory().makeVarOrders(new VariableOrder("name;age"));
    +        final PcjTables pcjs = new PcjTables();
             pcjs.createPcjTable(accumuloConn, pcjTableName, varOrders, sparql);
     
             // Add a few results to the PCJ table.
    -        MapBindingSet alice = new MapBindingSet();
    +        final MapBindingSet alice = new MapBindingSet();
             alice.addBinding("name", new URIImpl("http://Alice";));
             alice.addBinding("age", new NumericLiteralImpl(14, 
XMLSchema.INTEGER));
     
    -        MapBindingSet bob = new MapBindingSet();
    +        final MapBindingSet bob = new MapBindingSet();
             bob.addBinding("name", new URIImpl("http://Bob";));
             bob.addBinding("age", new NumericLiteralImpl(16, 
XMLSchema.INTEGER));
     
    -        MapBindingSet charlie = new MapBindingSet();
    +        final MapBindingSet charlie = new MapBindingSet();
             charlie.addBinding("name", new URIImpl("http://Charlie";));
             charlie.addBinding("age", new NumericLiteralImpl(12, 
XMLSchema.INTEGER));
     
    -        Set<BindingSet> results = Sets.<BindingSet>newHashSet(alice, bob, 
charlie);
    +        final Set<VisibilityBindingSet> results = 
Sets.<VisibilityBindingSet>newHashSet(
    +                new VisibilityBindingSet(alice),
    --- End diff --
    
    whitespace


> Add Visibility to Rya PCJs
> --------------------------
>
>                 Key: RYA-53
>                 URL: https://issues.apache.org/jira/browse/RYA-53
>             Project: Rya
>          Issue Type: New Feature
>            Reporter: Andrew Smith
>
> Update the PCJ api to support visibility attached to binding sets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)