Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/36#discussion_r59214884
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/FilterResultUpdater.java
---
@@ -126,11 +129,19 @@ public void updateFilterResults(
filterBindingSet.addBinding(binding);
}
}
- final String filterBindingSetString =
converter.convert(filterBindingSet, filterVarOrder);
- final Bytes row = encoder.encode( filterMetadata.getNodeId() +
NODEID_BS_DELIM + filterBindingSetString );
+ final String filterBindingSetIdString =
ID_CONVERTER.convert(filterBindingSet, filterVarOrder);
+ String filterBindingSetValueString = "";
+ if(childBindingSet instanceof VisibilityBindingSet) {
--- End diff --
We shouldn't do the type checking here. Assume it's always a
VisibilityBindingSet once it's within the Fluo app. Lets update the BindingSet
object that is passed into the updaters to require a VisibilityBindingSet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
