[ 
https://issues.apache.org/jira/browse/RYA-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235435#comment-15235435
 ] 

ASF GitHub Bot commented on RYA-53:
-----------------------------------

Github user isper3at commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/36#discussion_r59236612
  
    --- Diff: 
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/FilterResultUpdater.java
 ---
    @@ -126,11 +129,19 @@ public void updateFilterResults(
                         filterBindingSet.addBinding(binding);
                     }
                 }
    -            final String filterBindingSetString = 
converter.convert(filterBindingSet, filterVarOrder);
     
    -            final Bytes row = encoder.encode( filterMetadata.getNodeId() + 
NODEID_BS_DELIM + filterBindingSetString );
    +            final String filterBindingSetIdString = 
ID_CONVERTER.convert(filterBindingSet, filterVarOrder);
    +            String filterBindingSetValueString = "";
    +            if(childBindingSet instanceof VisibilityBindingSet) {
    --- End diff --
    
    I'll go through and update the interfaces?


> Add Visibility to Rya PCJs
> --------------------------
>
>                 Key: RYA-53
>                 URL: https://issues.apache.org/jira/browse/RYA-53
>             Project: Rya
>          Issue Type: New Feature
>            Reporter: Andrew Smith
>
> Update the PCJ api to support visibility attached to binding sets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to