Github user pujav65 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/48#discussion_r67527212
  
    --- Diff: 
dao/mongodb.rya/src/main/java/mvm/rya/mongodb/MongoDBQueryEngine.java ---
    @@ -44,153 +52,144 @@
     import mvm.rya.mongodb.iter.RyaStatementCursorIterable;
     import mvm.rya.mongodb.iter.RyaStatementCursorIterator;
     
    -import org.calrissian.mango.collect.CloseableIterable;
    -import org.openrdf.query.BindingSet;
    -
    -import com.mongodb.DB;
    -import com.mongodb.DBCollection;
    -import com.mongodb.DBObject;
    -import com.mongodb.MongoClient;
    -
     /**
      * Date: 7/17/12
      * Time: 9:28 AM
      */
     public class MongoDBQueryEngine implements 
RyaQueryEngine<MongoDBRdfConfiguration>, Closeable {
     
         private MongoDBRdfConfiguration configuration;
    -   private MongoClient mongoClient;
    -   private DBCollection coll;
    -   private MongoDBStorageStrategy strategy;
    -    
    -    public MongoDBQueryEngine(MongoDBRdfConfiguration conf) throws 
NumberFormatException, UnknownHostException{
    -           mongoClient = new 
MongoClient(conf.get(MongoDBRdfConfiguration.MONGO_INSTANCE),
    -                           
Integer.valueOf(conf.get(MongoDBRdfConfiguration.MONGO_INSTANCE_PORT)));
    -           DB db = mongoClient.getDB( 
conf.get(MongoDBRdfConfiguration.MONGO_DB_NAME));
    +   private final MongoClient mongoClient;
    --- End diff --
    
    no need to add all the finals


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to