[
https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387600#comment-15387600
]
ASF GitHub Bot commented on RYA-100:
------------------------------------
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/54#discussion_r71696281
--- Diff: pom.xml ---
@@ -562,6 +562,29 @@ under the License.
<target>1.7</target>
</configuration>
</plugin>
+
+ <!-- Fail a build if it uses any Java features introduced
after 1.7. -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>animal-sniffer-maven-plugin</artifactId>
+ <version>1.15</version>
+ <configuration>
+ <signature>
+ <groupId>org.codehaus.mojo.signature</groupId>
+ <artifactId>java17</artifactId>
--- End diff --
I think a later pull request upgrades rya back to java 8 (an upgrade that
was lost somehow when we ported to apache). Can you update this accordingly?
Then I will merge.
> Update the build to us Maven animal-sniffer plugin.
> ---------------------------------------------------
>
> Key: RYA-100
> URL: https://issues.apache.org/jira/browse/RYA-100
> Project: Rya
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.10
> Reporter: Kevin Chilton
> Assignee: Kevin Chilton
> Fix For: 3.2.10
>
>
> Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though,
> the build succeeds when Java 1.8 features are used within the source. This is
> a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the
> test phase of the build so that it will list where Java 1.8+ features are
> being used and fail the build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
