[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490751#comment-15490751
]
ASF GitHub Bot commented on RYA-151:
------------------------------------
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/85#discussion_r78775502
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -0,0 +1,250 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <parent>
+ <artifactId>rya.extras</artifactId>
+ <groupId>org.apache.rya</groupId>
+ <version>3.2.10-SNAPSHOT</version>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>rya.benchmark</artifactId>
+
+ <name>Apache Rya Benchmarks</name>
+
+ <dependencies>
+ <!-- JMH Benchmark Framework dependencies -->
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-core</artifactId>
+ <version>${jmh.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
+ <version>${jmh.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.rya</groupId>
+ <artifactId>rya.indexing</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>jsr305</artifactId>
+ <version>3.0.1</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-minicluster</artifactId>
+ <version>${accumulo.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ </dependencies>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <!--
+ JMH version to use with this project.
+ -->
+ <jmh.version>1.13</jmh.version>
+
+ <!--
+ Java source/target to use for compilation.
+ -->
+ <javac.target>1.8</javac.target>
+
+ <!--
+ Name of the benchmark Uber-JAR to generate.
+ -->
+ <uberjar.name>benchmarks</uberjar.name>
+ </properties>
+
+ <build>
+ <resources>
+ <resource>
+ <directory>src/main/xsd</directory>
+ </resource>
+ </resources>
+
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
--- End diff --
Sorry for my terse comment. These should be defined in the parent POM:
1. Versions for dependencies should be defined as parameters (e.g. like
you've done with jmh.version). You should also do this for maven plug-ins
(e.g. you haven't done this for maven-clean-plugin).
2. Dependencies (and plug-ins) and their versions should be defined in the
DependenciesManagement (and pluginManagement) sections of the root pom.
3. The root pom should be the only pom to define the java versions.
Subprojects shouldn't be using the maven-compiler-plugin to define their own
versions of java.
4. You have some nice plug-ins that should be moved to the root pom as well
(e.g. license-maven-plugin). I think @DLotts is working on this, so there's no
need for you to modify that here.
> Rya Test Bed
> ------------
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
> Reporter: Puja Valiyil
> Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
