[ 
https://issues.apache.org/jira/browse/RYA-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583211#comment-15583211
 ] 

ASF GitHub Bot commented on RYA-200:
------------------------------------

GitHub user amihalik opened a pull request:

    https://github.com/apache/incubator-rya/pull/115

    RYA-200 Removing findbugs:jsr305 Dependency

    ## Description
    
    Removed findbugs:jsr305 Dependency.  Replaced with findbugs-annotations.
    
    Several annotations are not available in findbugs-annotations.  These 
annotations where commented out and a new JIRA ticket (RYA-211) was created to 
deal with them:
    
    - @ThreadSafe
    - @Immutable
    - @ParametersAreNonnullByDefault
    
    ### Tests
    
    Current tests pass.  No New tests.
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-200)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Reivew
    @isper3at 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amihalik/incubator-rya RYA-200

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 13af4d4976a498db8c682d919d5b63fdb6528a98
Author: Aaron Mihalik <miha...@alum.mit.edu>
Date:   2016-10-17T19:20:39Z

    RYA-200 Removing findbugs:jsr305 Dependency
    
    Closes #115

----


> Remove findbugs:jsr305 Dependency
> ---------------------------------
>
>                 Key: RYA-200
>                 URL: https://issues.apache.org/jira/browse/RYA-200
>             Project: Rya
>          Issue Type: Task
>    Affects Versions: 3.2.10, 3.2.9
>            Reporter: Aaron Mihalik
>            Assignee: Aaron Mihalik
>            Priority: Blocker
>
> Per review notes from Josh:
> {quote}
> com.google.code.findbugs:jsr305 coming in via hadoop-common (yes, Hadoop
> screwed up) is also bad. This is an easy fix to exclude this dependency
> and add in com.github.stephenc.findbugs:findbugs-annotations instead.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to