[
https://issues.apache.org/jira/browse/RYA-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583483#comment-15583483
]
ASF GitHub Bot commented on RYA-200:
------------------------------------
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83734972
--- Diff:
extras/rya.console/src/main/java/org/apache/rya/shell/SharedShellState.java ---
@@ -23,10 +23,10 @@
import java.util.Objects;
import java.util.concurrent.locks.ReentrantLock;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
-import javax.annotation.concurrent.ThreadSafe;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
hurmmm? this intentional?
> Remove findbugs:jsr305 Dependency
> ---------------------------------
>
> Key: RYA-200
> URL: https://issues.apache.org/jira/browse/RYA-200
> Project: Rya
> Issue Type: Task
> Affects Versions: 3.2.10, 3.2.9
> Reporter: Aaron Mihalik
> Assignee: Aaron Mihalik
> Priority: Blocker
>
> Per review notes from Josh:
> {quote}
> com.google.code.findbugs:jsr305 coming in via hadoop-common (yes, Hadoop
> screwed up) is also bad. This is an easy fix to exclude this dependency
> and add in com.github.stephenc.findbugs:findbugs-annotations instead.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
