ASF GitHub Bot commented on RYA-200:

Github user amihalik commented on a diff in the pull request:

    --- Diff: 
extras/rya.console/src/main/java/org/apache/rya/shell/SharedShellState.java ---
    @@ -23,10 +23,10 @@
     import java.util.Objects;
     import java.util.concurrent.locks.ReentrantLock;
    -import javax.annotation.Nullable;
    -import javax.annotation.ParametersAreNonnullByDefault;
    -import javax.annotation.concurrent.Immutable;
    -import javax.annotation.concurrent.ThreadSafe;
    +import edu.umd.cs.findbugs.annotations.Nullable;
    --- End diff --
    Do you mean the new package name? Yeah, that's intentional but I don't know 
if it's correct.  I was told to use findbug-annotations, and that's where the 
nullable annotation lives. 

> Remove findbugs:jsr305 Dependency
> ---------------------------------
>                 Key: RYA-200
>                 URL: https://issues.apache.org/jira/browse/RYA-200
>             Project: Rya
>          Issue Type: Task
>    Affects Versions: 3.2.10, 3.2.9
>            Reporter: Aaron Mihalik
>            Assignee: Aaron Mihalik
>            Priority: Blocker
> Per review notes from Josh:
> {quote}
> com.google.code.findbugs:jsr305 coming in via hadoop-common (yes, Hadoop
> screwed up) is also bad. This is an easy fix to exclude this dependency
> and add in com.github.stephenc.findbugs:findbugs-annotations instead.
> {quote}

This message was sent by Atlassian JIRA

Reply via email to