GitHub user meiercaleb opened a pull request:
https://github.com/apache/incubator-rya/pull/125
Rya 222
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
>What Changed?
Historical results were being ingested into Fluo without column
visibilities. I fixed that. Also,
the FluoUpdater was being created with it's own visibility, which it
appended to the RyaStatements as it added them to Fluo. This was wrong in a
couple of ways. First, it was using authorizations for it's visibility, which
is incorrect. Secondly, as it is ingesting RyaStatements, it should just use
the visibility of the RyaStatement and not overwrite it's own when inserting
into Fluo. I modified the InsertTriples class to read the visibility from the
RyaStatement and use that as the visibility when writing to Fluo. The
FluoUpdater now uses the modified InsertTriples class to write RyaStatements
with the visibility assigned to the statement.
### Tests
I created an integration test to test that historical results are being
added with visibilities. I fixed another test that broke which tests whether
streamed triples are being assigned their visbilities from the RyaStatement.
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-222)
### Checklist
- [ ] Code Review
- [X] Squash Commits
#### People To Reivew
Aaron Mihalik, Puja Valiyil, Andrew Smith
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meiercaleb/incubator-rya RYA-222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit e5b315f0bcb4a1ec4aba26a258d26c3a42ace960
Author: Caleb Meier <[email protected]>
Date: 2016-11-22T16:39:09Z
RYA-224 Fluo Visibility Join Bug Fix
commit 6bafa7419044cfbfff780aab8fcbbaeca648b9a6
Author: Caleb Meier <[email protected]>
Date: 2016-11-30T17:07:33Z
RYA-222-Fixed Column Visibility Bug for Results Streamed into Fluo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
