Github user isper3at commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/124#discussion_r94812004
  
    --- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/document/operators/aggregation/PipelineOperators.java
 ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.rya.mongodb.document.operators.aggregation;
    +
    +import static 
org.apache.rya.mongodb.document.operators.query.ConditionalOperators.cond;
    +
    +import com.mongodb.BasicDBObject;
    +import com.mongodb.BasicDBObjectBuilder;
    +
    +/**
    + * Utility methods for pipeline operators.
    + */
    +public final class PipelineOperators {
    --- End diff --
    
    For all the *Operators, I think it would be helpful to make the functions 
return the actual BasicDBObjectBuilder.  That way you can supply each function 
with a builder and it appends the operation to it, making it a lot easier to 
spin up more complicated queries.
    
    If you have time to do this, awesome, if not we can open a ticket


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to