[ 
https://issues.apache.org/jira/browse/RYA-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977551#comment-15977551
 ] 

ASF GitHub Bot commented on RYA-260:
------------------------------------

Github user meiercaleb commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/156#discussion_r112551390
  
    --- Diff: 
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePCJ.java
 ---
    @@ -118,14 +116,14 @@ private void stopUpdatingPCJ(final String 
fluoAppName, final String pcjId) {
     
             // Connect to the Fluo application that is updating this 
instance's PCJs.
             final AccumuloConnectionDetails cd = 
super.getAccumuloConnectionDetails();
    -        final FluoClient fluoClient = new FluoClientFactory().connect(
    +        try(final FluoClient fluoClient = new FluoClientFactory().connect(
                     cd.getUsername(),
                     new String(cd.getPassword()),
                     cd.getInstanceName(),
                     cd.getZookeepers(),
    -                fluoAppName);
    -
    -        // Delete the PCJ from the Fluo App.
    -        new DeletePcj(1000).deletePcj(fluoClient, pcjId);
    --- End diff --
    
    It appears that you did not update DeletePcj to delete your aggregation 
results/metadata.


> Add Aggregation support for Fluo/PCJ app
> ----------------------------------------
>
>                 Key: RYA-260
>                 URL: https://issues.apache.org/jira/browse/RYA-260
>             Project: Rya
>          Issue Type: New Feature
>            Reporter: Andrew Smith
>            Assignee: Kevin Chilton
>
> A user must be able to submit a PCJ query that contains the following 
> aggregation functions from SPARQL:
> * Sum
> * Count
> * Average
> * Min
> * Max
> This task does not include any aggregations that appear within a GroupBy 
> clause. We only need to support queries that have the aggregation within the 
> SELECT section.
> For example, the following query should be processed:
> {code}
> SELECT (avg(?price) as ?averagePrice)
> {
>     urn:BookA urn:price ?price.
> }
> {code}
> And the following query should not be processed because it requires a group 
> by:
> {code}
> SELECT ?title (avg(?price) as ?averagePrice)
> {
>     ?title urn:price ?price.
> }
> GROUP BY ?title
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to