[
https://issues.apache.org/jira/browse/RYA-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979065#comment-15979065
]
ASF GitHub Bot commented on RYA-260:
------------------------------------
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/156#discussion_r112732124
--- Diff:
extras/rya.indexing.pcj/src/main/java/org/apache/rya/indexing/pcj/storage/accumulo/AccumuloPcjSerializer.java
---
@@ -112,24 +109,6 @@ public BindingSet convert(byte[] bindingSetBytes,
VariableOrder varOrder) throws
}
}
- /**
- * Checks to see if the names of all the {@link Binding}s in the
{@link BindingSet}
- * are a subset of the variables names in {@link VariableOrder}.
- *
- * @param bindingSet - The binding set whose Bindings will be
inspected. (not null)
- * @param varOrder - The names of the bindings that may appear in the
BindingSet. (not null)
- * @throws IllegalArgumentException Indicates the names of the
bindings are
- * not a subset of the variable order.
- */
- private static void checkBindingsSubsetOfVarOrder(BindingSet
bindingSet, VariableOrder varOrder) throws IllegalArgumentException {
- checkNotNull(bindingSet);
- checkNotNull(varOrder);
-
- Set<String> bindingNames = bindingSet.getBindingNames();
- List<String> varNames = varOrder.getVariableOrders();
- checkArgument(varNames.containsAll(bindingNames), "The BindingSet
contains a Binding whose name is not part of the VariableOrder.");
- }
-
--- End diff --
Though I think the logic of this method is actually backwards. It should be
checking to ensure the bindingNames contain all of the var names, not the other
way around. I could put this method back and fix the logic.
> Add Aggregation support for Fluo/PCJ app
> ----------------------------------------
>
> Key: RYA-260
> URL: https://issues.apache.org/jira/browse/RYA-260
> Project: Rya
> Issue Type: New Feature
> Reporter: Andrew Smith
> Assignee: Kevin Chilton
>
> A user must be able to submit a PCJ query that contains the following
> aggregation functions from SPARQL:
> * Sum
> * Count
> * Average
> * Min
> * Max
> This task does not include any aggregations that appear within a GroupBy
> clause. We only need to support queries that have the aggregation within the
> SELECT section.
> For example, the following query should be processed:
> {code}
> SELECT (avg(?price) as ?averagePrice)
> {
> urn:BookA urn:price ?price.
> }
> {code}
> And the following query should not be processed because it requires a group
> by:
> {code}
> SELECT ?title (avg(?price) as ?averagePrice)
> {
> ?title urn:price ?price.
> }
> GROUP BY ?title
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
