[
https://issues.apache.org/jira/browse/RYA-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059680#comment-16059680
]
ASF GitHub Bot commented on RYA-304:
------------------------------------
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/173#discussion_r123565355
--- Diff:
extras/rya.merger/src/test/java/org/apache/rya/accumulo/mr/merge/RulesetCopyIT.java
---
@@ -144,32 +146,33 @@ private static RyaType literal(final String lit,
final URI type) {
@BeforeClass
public static void setUpPerClass() throws Exception {
+ DemoUtilities.setupLogging(LoggingDetail.LIGHT);
accumuloDualInstanceDriver = new
AccumuloDualInstanceDriver(IS_MOCK, true, true, false, false);
accumuloDualInstanceDriver.setUpInstances();
}
@Before
public void setUpPerTest() throws Exception {
- parentConfig = accumuloDualInstanceDriver.getParentConfig();
- childConfig = accumuloDualInstanceDriver.getChildConfig();
- accumuloDualInstanceDriver.setUpTables();
accumuloDualInstanceDriver.setUpConfigs();
+ accumuloDualInstanceDriver.setUpTables();
accumuloDualInstanceDriver.setUpDaos();
+ parentConfig = accumuloDualInstanceDriver.getParentConfig();
+ childConfig = accumuloDualInstanceDriver.getChildConfig();
parentDao = accumuloDualInstanceDriver.getParentDao();
}
@After
public void tearDownPerTest() throws Exception {
log.info("tearDownPerTest(): tearing down now.");
- accumuloDualInstanceDriver.tearDownDaos();
accumuloDualInstanceDriver.tearDownTables();
+ accumuloDualInstanceDriver.tearDownDaos();
+ if (rulesetTool != null) {
+ rulesetTool.shutdown();
+ }
}
@AfterClass
public static void tearDownPerClass() throws Exception {
- if (rulesetTool != null) {
- rulesetTool.shutdown();
- }
accumuloDualInstanceDriver.tearDown();
--- End diff --
This way caused the tests to run faster and were a bit more reliable.
Trying to spin up a new MAC for each test and tear it down nearly doubled the
time for running the tests. It looked like more java processes were opened by
spinning up MACs for each test.
> Fix rya.merger Integration Tests
> --------------------------------
>
> Key: RYA-304
> URL: https://issues.apache.org/jira/browse/RYA-304
> Project: Rya
> Issue Type: Bug
> Components: build
> Affects Versions: 3.2.10
> Reporter: Eric White
> Assignee: Eric White
> Fix For: 3.2.10
>
>
> The integration tests for rya.merger are failing. The test that is failing
> is for RulesetCopyIT
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
