Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/188#discussion_r130113701
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/LoadStatementsFile.java
---
@@ -31,14 +31,16 @@
@DefaultAnnotation(NonNull.class)
public interface LoadStatementsFile {
- /**
- * Loads a local file of RDF statements into an instance of Rya.
- *
- * @param ryaInstanceName - The name of the Rya instance the
statements will be loaded into. (not null)
- * @param statementsFile - A file that holds RDF statements that will
be loaded. (not null)
- * @param format - The format of the statements file. (not null)
- * @throws InstanceDoesNotExistException No instance of Rya exists for
the provided name.
- * @throws RyaClientException Something caused the command to fail.
- */
- public void loadStatements(String ryaInstanceName, Path
statementsFile, RDFFormat format) throws InstanceDoesNotExistException,
RyaClientException;
+ /**
+ * Loads a local file of RDF statements into an instance of Rya.
+ *
+ * @param ryaInstanceName - The name of the Rya instance the statements
will be loaded into. (not null)
+ * @param statementsFile - A file that holds RDF statements that will
be loaded. (not null)
+ * @param format - The format of the statements file. (not null)
+ * @param flushEachUpdate - If true, each statement will be flushed
individually. If false, statements will be
+ * grouped in an unspecified manner. A value of false will
typically yield higher ingest rates.
+ * @throws InstanceDoesNotExistException No instance of Rya exists for
the provided name.
+ * @throws RyaClientException Something caused the command to fail.
+ */
+ public void loadStatements(String ryaInstanceName, Path
statementsFile, RDFFormat format, boolean flushEachUpdate) throws
InstanceDoesNotExistException, RyaClientException;
--- End diff --
Agree. It would be nice to have the option to override default connection
configs without disconnecting and reconnecting - especially for the case where
the user wants to quickly visualize the difference in results when
loading/querying data with different visibilities/authorizations. Would
require an API change which is out of scope for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
