ASF GitHub Bot commented on RYA-303:

Github user meiercaleb commented on a diff in the pull request:

    --- Diff: 
    @@ -0,0 +1,184 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.rya.indexing.mongodb.pcj;
    +import static com.google.common.base.Preconditions.checkNotNull;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import org.apache.accumulo.core.client.AccumuloException;
    +import org.apache.accumulo.core.client.AccumuloSecurityException;
    +import org.apache.accumulo.core.client.TableNotFoundException;
    +import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.rya.api.utils.IteratorWrapper;
    +import org.apache.rya.indexing.external.tupleSet.ExternalTupleSet;
    +import org.apache.rya.indexing.external.tupleSet.ParsedQueryUtil;
    +import org.apache.rya.indexing.pcj.matching.PCJOptimizerUtilities;
    +import org.apache.rya.indexing.pcj.storage.PcjException;
    +import org.apache.rya.indexing.pcj.storage.mongo.MongoPcjDocuments;
    +import org.apache.rya.rdftriplestore.evaluation.ExternalBatchingIterator;
    +import org.openrdf.query.BindingSet;
    +import org.openrdf.query.MalformedQueryException;
    +import org.openrdf.query.QueryEvaluationException;
    +import org.openrdf.query.algebra.Projection;
    +import org.openrdf.query.algebra.TupleExpr;
    +import org.openrdf.query.parser.ParsedTupleQuery;
    +import org.openrdf.query.parser.sparql.SPARQLParser;
    +import org.openrdf.sail.SailException;
    +import com.google.common.base.Optional;
    +import com.google.common.base.Preconditions;
    +import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
    +import edu.umd.cs.findbugs.annotations.NonNull;
    +import info.aduna.iteration.CloseableIteration;
    + * Indexing Node for PCJs expressions to be inserted into execution plan to
    + * delegate entity portion of query to {@link MongoPrecomputedJoinIndexer}.
    + */
    +public class PcjQueryNode extends ExternalTupleSet implements 
ExternalBatchingIterator {
    --- End diff --
    I think that you should make this name more Mongo centric.  PcjQueryNode 
sounds very general purpose and makes it seem like this class is DB agnostic.  
We should have similar naming conventions for the two PCJ nodes.  Currently the 
other node is AccumuloIndexSet.  If you don't like MongoIndexSet, we can rename 
that to AccumuloPcjNode and rename this class to MongoPcjNode.

> Mongo PCJ indexer support
> -------------------------
>                 Key: RYA-303
>                 URL: https://issues.apache.org/jira/browse/RYA-303
>             Project: Rya
>          Issue Type: Improvement
>            Reporter: Andrew Smith
>            Assignee: Andrew Smith

This message was sent by Atlassian JIRA

Reply via email to