Github user pujav65 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/199#discussion_r132243060
  
    --- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/dao/SimpleMongoDBStorageStrategy.java
 ---
    @@ -64,14 +68,14 @@
         @Override
         public void createIndices(final DBCollection coll){
             BasicDBObject doc = new BasicDBObject();
    -        doc.put(SUBJECT, 1);
    -        doc.put(PREDICATE, 1);
    +        doc.put(SUBJECT_HASH, 1);
    +        doc.put(PREDICATE_HASH, 1);
             coll.createIndex(doc);
    --- End diff --
    
    When the Mongo db backend was first implemented, you could only do indices 
over two fields-- the first is the primary index, the second the secondary 
index.  That may have changed since.  The indices we originally had were 
subject, predicate, object, and then subject/predicate, predicate/object, and 
object/subject.  The not including object type might be a bug, but I had 
thought that was addressed at some point.  Also one could argue that the single 
field indices were redundant-- I had wanted to test to see but never got around 
to it.
    If you can now index over more than two fields, then we might want to 
revisit this.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to