[ https://issues.apache.org/jira/browse/RYA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129410#comment-16129410 ]
ASF GitHub Bot commented on RYA-292: ------------------------------------ Github user ejwhite922 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/206#discussion_r133566575 --- Diff: sail/src/main/java/org/apache/rya/rdftriplestore/evaluation/FilterRangeVisitor.java --- @@ -27,63 +33,62 @@ import org.openrdf.model.Value; import org.openrdf.model.impl.BooleanLiteralImpl; import org.openrdf.query.QueryEvaluationException; -import org.openrdf.query.algebra.*; +import org.openrdf.query.algebra.Filter; +import org.openrdf.query.algebra.FunctionCall; +import org.openrdf.query.algebra.StatementPattern; +import org.openrdf.query.algebra.ValueConstant; +import org.openrdf.query.algebra.ValueExpr; +import org.openrdf.query.algebra.Var; import org.openrdf.query.algebra.helpers.QueryModelVisitorBase; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - -import static org.apache.rya.api.RdfCloudTripleStoreConstants.RANGE; - /** * Class FilterTimeIndexVisitor * Date: Apr 11, 2011 * Time: 10:16:15 PM */ -public class FilterRangeVisitor extends QueryModelVisitorBase { +public class FilterRangeVisitor extends QueryModelVisitorBase<Exception> { - private RdfCloudTripleStoreConfiguration conf; - private Map<Var, RangeValue> rangeValues = new HashMap<Var, RangeValue>(); + private final RdfCloudTripleStoreConfiguration conf; + private final Map<Var, RangeValue> rangeValues = new HashMap<Var, RangeValue>(); - public FilterRangeVisitor(RdfCloudTripleStoreConfiguration conf) { + public FilterRangeVisitor(final RdfCloudTripleStoreConfiguration conf) { this.conf = conf; } @Override - public void meet(Filter node) throws Exception { + public void meet(final Filter node) throws Exception { --- End diff -- Removed a warning. The rest was save actions. > Implement owl:intersectionOf inference > -------------------------------------- > > Key: RYA-292 > URL: https://issues.apache.org/jira/browse/RYA-292 > Project: Rya > Issue Type: Sub-task > Components: sail > Reporter: Jesse Hatfield > Assignee: Eric White > > An *{{owl:intersectionOf}}* expression defines the set of resources who > belong to all of a particular set of classes. > A basic implementation, if the ontology states that {{:Mother}} is the > intersection of {{:Parent}} and {{:Woman}}, should cause the inference engine > to: > 1. Rewrite query patterns {{?x rdf:type :Mother}} (the intersection type) to > check for resources that have both types {{:Parent}} and {{:Woman}} (as well > as check for resources that are explicitly stated to be {{:Mother}} s) > 2. Rewrite query patterns {{?y rdf:type :Parent}} (one of the intersecting > sets) to check for resources that are stated to be either {{:Mother}} or > {{:Parent}} , since belonging to the intersection type implies membership in > the component types. (Equivalent logic applies to {{Woman}} ) -- This message was sent by Atlassian JIRA (v6.4.14#64029)