Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/215#discussion_r135049554
--- Diff:
sail/src/main/java/org/apache/rya/rdftriplestore/inference/OneOfVisitor.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.rdftriplestore.inference;
+
+import java.util.LinkedHashSet;
+import java.util.Set;
+
+import org.apache.log4j.Logger;
+import org.apache.rya.api.RdfCloudTripleStoreConfiguration;
+import org.openrdf.model.Resource;
+import org.openrdf.model.URI;
+import org.openrdf.model.vocabulary.RDF;
+import org.openrdf.query.BindingSet;
+import org.openrdf.query.algebra.BindingSetAssignment;
+import org.openrdf.query.algebra.StatementPattern;
+import org.openrdf.query.algebra.Var;
+import org.openrdf.query.algebra.evaluation.QueryBindingSet;
+
+/**
+ * Visitor for handling owl:oneOf inferencing on a node.
+ */
+public class OneOfVisitor extends AbstractInferVisitor {
+ private static final Logger log = Logger.getLogger(OneOfVisitor.class);
+
+ /**
+ * Creates a new instance of {@link OneOfVisitor}.
+ * @param conf the {@link RdfCloudeTripleStoreConfiguration}.
+ * @param inferenceEngine the {@link InferenceEngine}.
+ */
+ public OneOfVisitor(final RdfCloudTripleStoreConfiguration conf, final
InferenceEngine inferenceEngine) {
+ super(conf, inferenceEngine);
+ include = conf.isInferOneOf();
+ }
+
+ @Override
+ protected void meetSP(final StatementPattern node) throws Exception {
+ final Var subVar = node.getSubjectVar();
+ final Var predVar = node.getPredicateVar();
+ final Var objVar = node.getObjectVar();
+ final Var conVar = node.getContextVar();
+ if (predVar != null && objVar != null && objVar.getValue() != null
&& RDF.TYPE.equals(predVar.getValue()) && !EXPANDED.equals(conVar)) {
+ final URI object = (URI) objVar.getValue();
+ if (inferenceEngine.isEnumeratedType(object)) {
+ final Set<BindingSet> solutions = new LinkedHashSet<>();
+ final Set<Resource> enumeration =
inferenceEngine.getEnumeration(object);
+ if (enumeration != null && !enumeration.isEmpty()) {
--- End diff --
If getEnumeration returned an empty Set (if no enumerations existed), you
wouldn't need this check. Also, doesn't isEnumeratedType(...) = true ->
enumeration != null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
