Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/220#discussion_r136569934
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/CreatePCJ.java ---
@@ -44,7 +44,7 @@
* Application.
*
*/
- public static enum ExportStrategy{RYA, KAFKA, NO_OP_EXPORT};
+ public static enum ExportStrategy{RYA_EXPORT, KAFKA_EXPORT,
NO_OP_EXPORT, PERIODIC_EXPORT};
--- End diff --
Hmm, since you can have multiple export strategies, I don't see why we
can't just remove the `NO_OP_EXPORT` enum and the `NoOpExporter` class
entirely. If you get an empty set of strategies, that means you never have to
obtain an exporter that doesn't do anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
