[ https://issues.apache.org/jira/browse/RYA-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169034#comment-16169034 ]
ASF GitHub Bot commented on RYA-373: ------------------------------------ GitHub user DLotts opened a pull request: https://github.com/apache/incubator-rya/pull/229 RYA-373 Make Benchmarks optional by profile ## Description Made the extras/Benchmarks not part of the default build, enable with -P benchmark ### Tests none ### Links [Jira](https://issues.apache.org/jira/browse/373) ### Checklist - [ ] Code Review - [ ] Squash Commits #### People To Reivew anyone. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DLotts/incubator-rya RYA-373-optional-Benchmarks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 ---- commit 9a48261373abb7c81aa788423c9374c7d51d407e Author: David Lotts <david.lo...@parsons.com> Date: 2017-09-16T19:48:14Z RYA-373 made module only compile if mvn -P benchmark re incompatible library ---- > Benchmarks: JMH library cannot be distributed, make optional or replace > ----------------------------------------------------------------------- > > Key: RYA-373 > URL: https://issues.apache.org/jira/browse/RYA-373 > Project: Rya > Issue Type: Task > Affects Versions: 3.2.10 > Environment: We use JMH libraries for benchmark code. JMH uses the > GPL with classpath exception which is explicitly not compatible. > The recommendation is to make a profile so that the benchmark jar it is not > included with the release -or- find a replacement. > (GNU General Public License (GPL), version 2, with the Classpath > exception) JMH Core (org.openjdk.jmh:jmh-core:1.13 - > http://openjdk.java.net/projects/code-tools/jmh/jmh-core/) > (GNU General Public License (GPL), version 2, with the Classpath > exception) JMH Generators: Annotation Processors > (org.openjdk.jmh:jmh-generator-annprocess:1.13 > - http://openjdk.java.net/projects/code-tools/jmh/jmh-generator-annprocess/) > Reporter: David W. Lotts > Fix For: 3.2.12 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)