Github user jdasch commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/227#discussion_r139505373
  
    --- Diff: extras/rya.giraph/pom.xml ---
    @@ -35,6 +35,13 @@ under the License.
                 <groupId>org.apache.giraph</groupId>
                 <artifactId>giraph-core</artifactId>
                 <version>1.2.0</version>
    +            <exclusions>
    +                   <!-- exclude for incompatible license -->
    +                <exclusion>
    +                    <artifactId>json</artifactId>
    +                    <groupId>org.json</groupId>
    +                </exclusion>
    +            </exclusions>
    --- End diff --
    
    This change should be sufficient:
    ```
        <dependencies>
    <!--         
            Uncomment the following drop-in replacement if the exclusion
            of the dependency org.json:json causes issues at runtime.
            <dependency>
                <groupId>com.tdunning</groupId>
                <artifactId>json</artifactId>
                <version>1.8</version>
                <scope>runtime</scope>
            </dependency>
     -->       
            <dependency>
                <groupId>org.apache.giraph</groupId>
                <artifactId>giraph-core</artifactId>
                <version>1.2.0</version>
                <exclusions>
                    <!-- org.json:json excluded for incompatible license -->
                    <exclusion>
                        <groupId>org.json</groupId>
                        <artifactId>json</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
            <dependency>
                <groupId>org.apache.giraph</groupId>
                <artifactId>giraph-accumulo</artifactId>
                <version>1.2.0</version>
                <exclusions>
                    <!-- org.json:json excluded for incompatible license -->
                    <exclusion>
                        <groupId>org.json</groupId>
                        <artifactId>json</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
    ```


---

Reply via email to