[ 
https://issues.apache.org/jira/browse/RYA-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200750#comment-16200750
 ] 

ASF GitHub Bot commented on RYA-402:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/242#discussion_r144101585
  
    --- Diff: test/kafka/pom.xml ---
    @@ -0,0 +1,82 @@
    +<?xml version="1.0" encoding="utf-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +
    +    <parent>
    +        <groupId>org.apache.rya</groupId>
    +        <artifactId>rya.test.parent</artifactId>
    +        <version>3.2.12-incubating-SNAPSHOT</version>
    +    </parent>
    +    
    +    <modelVersion>4.0.0</modelVersion>
    +    <artifactId>rya.test.kafka</artifactId>
    +    
    +    <name>Apache Rya Test Kafka</name>
    +    <description>
    +        This module contains the Rya Test Kakfa components that help write 
Kafka
    +        based integration tests.
    +    </description>
    +
    +    <dependencies>
    +        <!-- Kafka dependencies. -->
    +        <dependency>
    +            <groupId>org.apache.kafka</groupId>
    +            <artifactId>kafka-clients</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.kafka</groupId>
    +            <artifactId>kafka-clients</artifactId>
    +            <classifier>test</classifier>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.kafka</groupId>
    +            <artifactId>kafka_2.11</artifactId>
    +            <exclusions>
    +                <exclusion>
    +                    <artifactId>slf4j-log4j12</artifactId>
    +                    <groupId>org.slf4j</groupId>
    +                </exclusion>
    +            </exclusions>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.kafka</groupId>
    +            <artifactId>kafka_2.11</artifactId>
    +            <classifier>test</classifier>
    +            <scope>compile</scope>
    +            <exclusions>
    +                <exclusion>
    +                    <artifactId>slf4j-log4j12</artifactId>
    +                    <groupId>org.slf4j</groupId>
    +                </exclusion>
    +            </exclusions>
    +        </dependency>
    +    
    +        <!-- Testing dependencies. -->
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <version>4.12</version>
    --- End diff --
    
    Removed.


> Create Kafka reusable test code project.
> ----------------------------------------
>
>                 Key: RYA-402
>                 URL: https://issues.apache.org/jira/browse/RYA-402
>             Project: Rya
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 3.2.11
>            Reporter: Kevin Chilton
>            Assignee: Kevin Chilton
>             Fix For: 3.2.12
>
>
> Create the parent project for all 3rd party tech test jar artifacts. It will 
> be a child of rya-project and the module will be named "test".
> Then have a project within the test parent for the Kafka components that 
> currently reside within the "rya.pcj.fluo.test.base" project.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to