[
https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211432#comment-16211432
]
ASF GitHub Bot commented on RYA-405:
------------------------------------
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/245#discussion_r145730329
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/domain/RyaType.java ---
@@ -93,10 +93,7 @@ public boolean equals(final Object o) {
if (data != null ? !data.equals(ryaType.data) : ryaType.data !=
null) {
return false;
}
- if (dataType != null ? !dataType.equals(ryaType.dataType) :
ryaType.dataType != null) {
- return false;
- }
- return true;
+ return dataType != null ? dataType.equals(ryaType.dataType) :
ryaType.dataType == null;
--- End diff --
While in here, I'd just have the equals() method use an EqualsBuilder so
all the inline-if's that were here before can be removed:
```
public boolean equals(final Object o) {
if (o == this) {
return true;
}
if (o == null || !(o instanceof RyaType)) {
return false;
}
final RyaType other = (RyaType) o;
final EqualsBuilder builder = new EqualsBuilder()
.append(getData(), other.getData())
.append(getDataType(), other.getDataType());
return builder.isEquals();
}
```
> Migrate from Sesame to rdf4j libs
> ----------------------------------
>
> Key: RYA-405
> URL: https://issues.apache.org/jira/browse/RYA-405
> Project: Rya
> Issue Type: Improvement
> Affects Versions: 3.2.12
> Reporter: Jorge Machado
>
> I have migrated all the project to the newer libs from rdf4j instead of using
> the old ones.
> Can someone take a look ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
