Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148546455
--- Diff:
extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplicationConfiguration.java
---
@@ -85,170 +85,170 @@ public
PeriodicNotificationApplicationConfiguration(Properties props) {
setPrunerThreads(Integer.parseInt(props.getProperty(PRUNER_THREADS,
"1")));
setCoordinatorThreads(Integer.parseInt(props.getProperty(COORDINATOR_THREADS,
"1")));
}
-
+
/**
* Sets the name of the Fluo Application
- * @param fluoAppName
+ * @param fluoAppName
*/
- public void setFluoAppName(String fluoAppName) {
- set(FLUO_APP_NAME, Preconditions.checkNotNull(fluoAppName));
+ public void setFluoAppName(final String fluoAppName) {
+ set(FLUO_APP_NAME, Objects.requireNonNull(fluoAppName));
--- End diff --
I see what you're saying (bonus points for finding char length irony!), but
the semantics of the public modifier are fixed and known. The method qualifier
could be anything, that's why I prefer to leave it in. Again, it is just a
preference and I'm happy to switch to a static import if this is a sticking
point.
---
