Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/251#discussion_r153007773
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.api/src/main/java/org/apache/rya/indexing/pcj/fluo/api/InsertTriples.java
---
@@ -116,7 +116,7 @@ public void insert(final FluoClient fluo, final
Collection<RyaStatement> triples
for(final RyaStatement triple : triples) {
Optional<byte[]> visibility =
Optional.fromNullable(triple.getColumnVisibility());
try {
- tx.set(Bytes.of(spoFormat(triple)),
FluoQueryColumns.TRIPLES, Bytes.of(visibility.or(new byte[0])));
+ tx.set(spoFormat(triple), FluoQueryColumns.TRIPLES,
Bytes.of(visibility.or(new byte[0])));
--- End diff --
the new byte[0] looks to be an empty visibility? Could you bring this up
to a final static class var, this might also be something nice to see in the
ColumnVisibility class
---
