[GitHub] incubator-rya pull request #251: Candidate/rya 406

[kchilton2]

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/251#discussion_r153252294
  
    --- Diff: 
extras/rya.pcj.fluo/pcj.fluo.api/src/main/java/org/apache/rya/indexing/pcj/fluo/api/DeleteFluoPcj.java
 ---
    @@ -131,10 +134,15 @@ private void deleteMetadata(final Transaction tx, 
final List<String> nodeIds, fi
             requireNonNull(pcjId);
     
             try (final Transaction typeTx = tx) {
    --- End diff --
    
    This try block is a little unclear if you are unfamiliar with this code 
already. Could you add some in line docs indicating the first loop removes the 
metadata the app uses to evaluate statement patterns, then the second remove 
call updates the list of SP IDs that are used for whatever they are used for? 


---