Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/251#discussion_r153570806
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/BindingSetRow.java
---
@@ -21,15 +21,16 @@
import static com.google.common.base.Preconditions.checkNotNull;
import static
org.apache.rya.indexing.pcj.fluo.app.IncrementalUpdateConstants.NODEID_BS_DELIM;
+import org.apache.commons.lang.builder.EqualsBuilder;
import org.apache.fluo.api.data.Bytes;
+import
org.apache.rya.indexing.pcj.fluo.app.util.BindingHashShardingFunction;
import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
import edu.umd.cs.findbugs.annotations.NonNull;
import net.jcip.annotations.Immutable;
/**
- * The values of an Accumulo Row ID for a row that stores a Binding set for
- * a specific Node ID of a query.
+ * The values of an Accumulo Row ID for a row that stores a Binding set
for a specific Node ID of a query.
--- End diff --
I don't think this is the appropriate place to document this. I added
documentation to the class BindingHashShardingFunction about how the sharded
row id is created and linked this class to the makeFromShardRow(...) method in
BindingSetRow.
---