[
https://issues.apache.org/jira/browse/RYA-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308746#comment-16308746
]
ASF GitHub Bot commented on RYA-414:
------------------------------------
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159312925
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/statement/metadata/matching/RyaQueryEngineFactory.java
---
@@ -64,12 +60,13 @@
throw new RuntimeException(e);
}
return (RyaQueryEngine<C>) new AccumuloRyaQueryEngine(conn,
aConf);
- } else if(conf instanceof MongoDBRdfConfiguration &&
conf.getBoolean("sc.useMongo", false)) {
- MongoClient client =
MongoConnectorFactory.getMongoClient(conf);
- return (RyaQueryEngine<C>) new
MongoDBQueryEngine((MongoDBRdfConfiguration) conf, client);
+ } else if(conf instanceof StatefulMongoDBRdfConfiguration &&
conf.getBoolean("sc.useMongo", false)) {
--- End diff --
There's a constant for "sc.useMongo" inside ConfigUtils. Maybe use that
here or move that constant to MongoDBRdfConfiguration and use it.
> Fix inconsistent method of using MongoClient within a Sail object
> -----------------------------------------------------------------
>
> Key: RYA-414
> URL: https://issues.apache.org/jira/browse/RYA-414
> Project: Rya
> Issue Type: Bug
> Reporter: Andrew Smith
> Assignee: Kevin Chilton
> Priority: Blocker
>
> We've decided to introduce a stateful configuration object that is used to
> hold onto objects that needs to be shared across components within a Sail
> object in favor of having a static holder. The static holder limited our
> ability to use more than a single Sail object within a single JVM because all
> of those Sail objects would all have to access the same Mongo DB repository.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
