Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/172#discussion_r160514908
  
    --- Diff: 
extras/indexing/src/main/java/org/apache/rya/api/client/mongo/MongoInstall.java 
---
    @@ -191,26 +192,22 @@ private static MongoDBRdfConfiguration makeRyaConfig(
     
             final MongoDBRdfConfiguration conf = 
connectionDetails.build(ryaDetails.getRyaInstanceName());
     
    -        // The Mongo implementation of Rya does not currently support PCJs.
    -        if(ryaDetails.getPCJIndexDetails().isEnabled()) {
    -            log.warn("The install configuration says to enable PCJ 
indexing, but Mongo RYA does not support that " +
    -                    "feature. Ignoring this configuration.");
    -        }
    -        conf.set(ConfigUtils.USE_PCJ, "false");
    +        conf.setBoolean(ConfigUtils.USE_PCJ, 
ryaDetails.getPCJIndexDetails().isEnabled());
     
             // Mongo does not support entity indexing.
             if(ryaDetails.getEntityCentricIndexDetails().isEnabled()) {
                 log.warn("The install configuration says to enable Entity 
Centric indexing, but Mongo RYA does not support " +
                         "that feature. Ignoring this configuration.");
             }
    -        conf.set(ConfigUtils.USE_ENTITY, "false");
    +        //TODO mongo now has an entity index, just needs CLI support.
    --- End diff --
    
    Address the TODOs and out of date comments in there. Should figure out if 
we're doing entity centric stuff in this ticket or not.


---

Reply via email to