[ 
https://issues.apache.org/jira/browse/RYA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319458#comment-16319458
 ] 

ASF GitHub Bot commented on RYA-410:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/252#discussion_r160563035
  
    --- Diff: pom.xml ---
    @@ -144,7 +141,83 @@ under the License.
             <skip.rya.it>true</skip.rya.it>  <!-- modified by  -P enable-it  
-->
         </properties>
         
    +    <!-- Enable this profile if you want to include Geo functions within 
Rya. "mvn ... -P geoindexing" -->
         <profiles>
    +        <profile>
    +            <id>geoindexing</id>
    +            <properties>
    +                <geomesa.version>1.3.0-m1</geomesa.version> <!-- Newest: 
1.3.0-m1 -->
    +                <geowave.version>0.9.3</geowave.version> <!-- Newest: 
0.9.3 -->
    +                <jts.version>1.13</jts.version>
    +            </properties>
    +            <dependencyManagement>
    --- End diff --
    
    I'm not worried about the eclipse problem since as you said, you can 
trivially tell eclipse to resolve using the geoindexing profile.
    
    The transitive dependency problem exists regardless of how dependency 
management is defined since the management section only defines dependencies 
that CAN be used, not the dependencies that ARE used. Actual dependencies are 
required to change that. If we're pulling down different transitive 
dependencies between geo on and geo off, that's already happening sans this 
patch.


> Add geo profile dependency management to the rya-project pom file.
> ------------------------------------------------------------------
>
>                 Key: RYA-410
>                 URL: https://issues.apache.org/jira/browse/RYA-410
>             Project: Rya
>          Issue Type: Improvement
>            Reporter: Kevin Chilton
>            Assignee: Kevin Chilton
>
> Right now the geo indexing feature of Rya is an optional portion of Rya that 
> is not built by default because it is not compatible with the Apache license. 
> However, geo dependencies are declared at the top of the project as if it all 
> builds depend on them. The top level pom file needs to be updated to include 
> the geoindexing profile and all artifacts related to that build need to be 
> moved to that profile's dependency management section.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to