Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/265#discussion_r162173884
  
    --- Diff: 
extras/rya.streams/api/src/main/java/org/apache/rya/streams/api/queries/QueryChange.java
 ---
    @@ -37,9 +37,11 @@
     @DefaultAnnotation(NonNull.class)
     public final class QueryChange implements Serializable {
         private static final long serialVersionUID = 1L;
    +
         private final UUID queryId;
         private final ChangeType changeType;
         private final Optional<String> sparql;
    +    private final Optional<Boolean> isActive;
    --- End diff --
    
    Null objects are ambiguous and prone to NPEs, so I avoid using them.


---

Reply via email to