[
https://issues.apache.org/jira/browse/RYA-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341591#comment-16341591
]
ASF GitHub Bot commented on RYA-440:
------------------------------------
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/267#discussion_r164219745
--- Diff:
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/KafkaRyaStreamsClientFactory.java
---
@@ -0,0 +1,169 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.streams.kafka;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Properties;
+import java.util.UUID;
+
+import org.apache.kafka.clients.CommonClientConfigs;
+import org.apache.kafka.clients.consumer.Consumer;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.Producer;
+import org.apache.kafka.clients.producer.ProducerConfig;
+import org.apache.kafka.common.serialization.Deserializer;
+import org.apache.kafka.common.serialization.Serializer;
+import org.apache.kafka.common.serialization.StringDeserializer;
+import org.apache.kafka.common.serialization.StringSerializer;
+import org.apache.rya.streams.api.RyaStreamsClient;
+import org.apache.rya.streams.api.interactor.defaults.DefaultAddQuery;
+import org.apache.rya.streams.api.interactor.defaults.DefaultDeleteQuery;
+import org.apache.rya.streams.api.interactor.defaults.DefaultGetQuery;
+import org.apache.rya.streams.api.interactor.defaults.DefaultListQueries;
+import org.apache.rya.streams.api.interactor.defaults.DefaultStartQuery;
+import org.apache.rya.streams.api.interactor.defaults.DefaultStopQuery;
+import org.apache.rya.streams.api.queries.InMemoryQueryRepository;
+import org.apache.rya.streams.api.queries.QueryChange;
+import org.apache.rya.streams.api.queries.QueryChangeLog;
+import org.apache.rya.streams.api.queries.QueryRepository;
+import org.apache.rya.streams.kafka.interactor.KafkaGetQueryResultStream;
+import org.apache.rya.streams.kafka.queries.KafkaQueryChangeLog;
+import
org.apache.rya.streams.kafka.serialization.VisibilityBindingSetDeserializer;
+import
org.apache.rya.streams.kafka.serialization.VisibilityStatementDeserializer;
+import
org.apache.rya.streams.kafka.serialization.queries.QueryChangeDeserializer;
+import
org.apache.rya.streams.kafka.serialization.queries.QueryChangeSerializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+/**
+ * Constructs instances of {@link RyaStreamsClient} that are connected to
a Kafka cluster.
+ */
+@DefaultAnnotation(NonNull.class)
+public final class KafkaRyaStreamsClientFactory {
+ private static final Logger log =
LoggerFactory.getLogger(KafkaRyaStreamsClientFactory.class);
+
+ /**
+ * Initialize a {@link RyaStreamsClient} that will interact with an
instance of Rya Streams
+ * that is backed by Kafka.
+ *
+ * @param ryaInstance - The name of the Rya Instance the client is
connected to. (not null)
+ * @param kafkaHostname - The hostname of the Kafka Broker.
+ * @param kafkaPort - The port of the Kafka Broker.
+ * @return The initialized commands.
+ */
+ public static RyaStreamsClient make(
+ final String ryaInstance,
+ final String kafkaHostname,
+ final int kafkaPort) {
+ requireNonNull(kafkaHostname);
--- End diff --
Null check on ryaInstance
> Rya Streams: Integration with the existing Rya Shell.
> -----------------------------------------------------
>
> Key: RYA-440
> URL: https://issues.apache.org/jira/browse/RYA-440
> Project: Rya
> Issue Type: Task
> Reporter: Kevin Chilton
> Assignee: Kevin Chilton
> Priority: Major
>
> We need a way to interact with Rya Streams. The shell should include the
> following commands:
> * *streams-configure*: Lets you change which Rya Streams system an instance
> of Rya is configured to use. For example, if you are using Kafka Streams,
> this command would let you configure where the Kafka services are found.
> * *streams-details*: Prints to the screen the currently configured values.
> * *streams-queries-add*: Tells Rya Streams that it needs to maintain a query
> * *streams-queries-delete*: Tells Rya Streams that it no longer needs to
> maintain a query.
> * *streams-queries-start*: Tells Rya Streams to start maintaining a query.
> * *streams-queries-stop*: Tells Rya Streams to stop maintaining a query.
> * *streams-queries-list*: Lists the queries that are being maintained by Rya
> Streams as well as their start/stop state.
> * *streams-queries-details*: Prints details about the query.
> For this iteration, no PCJ integration will be supported.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
