[
https://issues.apache.org/jira/browse/RYA-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350381#comment-16350381
]
ASF GitHub Bot commented on RYA-459:
------------------------------------
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/269#discussion_r165655934
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/accumulo/AccumuloIndexingConfiguration.java
---
@@ -287,15 +286,19 @@ public void setAccumuloTemporalPredicates(String[]
predicates) {
public String[] getAccumuloTemporalPredicates() {
return getStrings(ConfigUtils.TEMPORAL_PREDICATES_LIST);
}
-
- private static Set<RyaURI> getPropURIFromStrings(String ... props) {
- Set<RyaURI> properties = new HashSet<>();
- for(String prop: props) {
- properties.add(new RyaURI(prop));
+
+ private static Set<RyaURI> getPropURIFromStrings(final String...
props) {
+ final Set<RyaURI> properties = new HashSet<>();
+ if (props != null) {
+ for(final String prop : props) {
+ if (prop != null) {
--- End diff --
Do we want/need an empty string check here? Do we need/have a unit test to
exercise this?
> metadata.properties configuration error
> ---------------------------------------
>
> Key: RYA-459
> URL: https://issues.apache.org/jira/browse/RYA-459
> Project: Rya
> Issue Type: Bug
> Components: dao
> Affects Versions: 3.2.12
> Reporter: Eric White
> Assignee: Eric White
> Priority: Major
> Fix For: 3.2.12
>
>
> AccumuloIndexingConfiguration does not parse the metadata.properties tag
> properly. It is not null safe like the other tags and does not split the
> comma-separated list. The other tags provide a default if null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
